-
Notifications
You must be signed in to change notification settings - Fork 488
DPL: improve type_to_task_name function #15006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ktf
commented
Jan 30, 2026
- Out of line and avoid usage of stringstream.
- Remove non-sense abbreviations
- Out of line and avoid usage of stringstream. - Remove non-sense abbreviations
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
Apart from some detectors and ALICE3 I most notably missed "MC" as an abbreviation. I suggest to add those in a separate PR. In any case, it should behave as before in the worst case scenario. |
|
Hello @ktf |
|
@mhemmer-cern yes, of course. As I said, please let's see this PR green and merge it and then we can add everything which is missing. |
|
How many wagons will break because of the changed device names? |
|
Tested on hyperloop. Merging. |
|
I just did a quick test with one task that I have that is affected by this change. |
|
You mean that you have something which was -e-m-c and that becomes -emc? |
exactly, it was task-pi0-flow-e-m-c and is now task-pi0-flow-emc. |
|
I have found 36 affected workflows. I suspect that the number of affected wagons is much larger. |
|
I can remove "-emc" and "-emcal" from the list, if you prefer, and then we allow people to migrate with proper instructions and so on. |
For me personally it is fine. I knew this change was coming and I was able to migrate properly. I just think that we should announce this change in the proper channel to make sure everyone affected is prepared. |
|
Hi everyone, indeed, this is a little dangerous. On the positive side, last time I had something like this, the task was broken but switching to the new executable (straight from the old executable) made Hyperloop retain all configurable values - but if one switches to the wrong executables, there might be troubles as the sync might destroy the existing configurations. I agree it would be better to announce this maybe tomorrow morning, just in case. Thanks! |
I don't think it can work the same with devices. There is no way that Hyperloop can be told to port configuration of one JSON block into another one. |
You may be right, indeed: in my case it was only the executable name that changed ... |
|
Let's discuss this tomorrow. I can either rollback the exceptions which break (which one?) or we can add an exception to the exceptions if applicable (e.g., adding {"e-m-c", "-e-m-c"} would have solved the incompatibility as well. |